fix: Presto timestamp rounding and issue cleanup#26
Open
Conversation
The rounds=True and rounds=False branches in Presto's normalize_timestamp produced identical SQL, silently ignoring the rounding flag. Cast to coltype.precision (not 6) when rounding, matching Trino's correct implementation. Also clarify the misleading TODO in Join.select — column validation is already handled by resolve_names(). Closes #13 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
resolve_names() performs name resolution (raises on unknown names), not general column validation. Updated comment to accurately describe the behavior. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
resolve_names() raises KeyError (not a generic error) and only validates when schema is present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_timestampwhererounds=Truesilently ignored rounding — both branches produced identical SQL casting totimestamp(6). Now casts totimestamp(coltype.precision)when rounding, matching Trino's implementation.Join.select— column validation is already handled byresolve_names().Test plan
uv run pytest tests/test_query.py -x -q— 32 passedtrino.py:22Closes #13
🤖 Generated with Claude Code